googleapis / google-oauth-java-client

Google OAuth Client Library for Java
Apache License 2.0
615 stars 270 forks source link

chore: Update ci.yaml for Java 21 unit testing #1086

Open ddixit14 opened 1 year ago

ddixit14 commented 12 months ago

ci / units (21) (pull_request) failing with:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project google-oauth-client: Compilation failure: Compilation failure: 
Error: [ERROR] error: Source option 7 is no longer supported. Use 8 or later.
Error: [ERROR] error: Target option 7 is no longer supported. Use 8 or later.
suztomo commented 12 months ago

How about "Compile with Java 8 and run tests in Java 21"? We want to ensure that the libraries published from this repository are compatible with Java 21 users.

The sdk-platform-java repository has "Compile with Java 17 and run tests with Java 8" in https://github.com/googleapis/sdk-platform-java/blob/main/.github/workflows/ci.yaml#L74