search

googleapis / google-p12-pem

**THIS REPOSITORY AND PACKAGE WILL BE DEPRECATED IN JULY 2024** Convert Google .p12 keys to .pem keys.
MIT License
26 stars 22 forks source link

fix(deps): update node-forge to 0.10.0 #348

Closed chingor13 closed 3 years ago

chingor13 commented 3 years ago

Fixes #337

chingor13 commented 3 years ago

Wait for ci tests and branch protection

JustinBeckwith commented 3 years ago

I approve, but I am also a little worried about system tests. This version of the library probably needed to run on node 6, and I think our system tests are at 12. Short of quickly finding a way to make GitHub Actions work for system/sample tests, I don't have an easy answer here. Maybe locally npm install 6 and run the system tests on this branch to be 100% sure?

bcoe commented 3 years ago

Good news is that node-forge claims to still support Node 6:

  "engines": {
    "node": ">= 6.0.0"
  },
chingor13 commented 3 years ago

The system tests/samples themselves don't work on node 6. See #352 - util.promisify was introduced in node 8 and async functions were not available until node 7.6.

At this point in time, the system tests/samples were run on node 8 which is passing. See #353