feature request: move away from utilizing node-forge

googleapis / google-p12-pem

**THIS REPOSITORY AND PACKAGE WILL BE DEPRECATED IN JULY 2024** Convert Google .p12 keys to .pem keys.

MIT License

26 stars 22 forks source link

feature request: move away from utilizing node-forge #419

Closed ddelgrosso1 closed 1 year ago

ddelgrosso1 commented 2 years ago

Currently this library utilizes node-forge to convert between p12 format and pem format. According to bundlephobia node-forge currently accounts for ~35% of the size of NodeJS Storage. Considering we are utilizing a very limited amount of node-forge functionality we should investigate the possibility of moving away from it for something lighter weight.

ddelgrosso1 commented 2 years ago

Created this to better track the comments in https://github.com/googleapis/google-p12-pem/issues/414

mehboob-alam81 commented 1 year ago

Is there an ETA for this to be completed?

ddelgrosso1 commented 1 year ago

We decided to remove google-p12-pem further up the chain of auth flow (https://github.com/googleapis/node-gtoken/pull/452). As a result it is unlikely we will remove node-forge from this library. Closing as a result.