fix: rate limiting should be ineffective when RateLimitInfo is not present

kongweihan commented 3 months ago

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
[x] Ensure the tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)
[x] Rollback plan is reviewed and LGTMed
[x] All new data plane features have a completed end to end testing plan

Fixes # ☕️

If you write sample code, please follow the samples format.

kongweihan commented 3 months ago

@igorbernstein2 what kind of rollback plan we could implement for such changes?

igorbernstein2 commented 3 months ago

re rollback - this is the rollback mechanism for the throttling feature. I dont think we need a rollback mechanism for the the rollback mechanism :)

conventional-commit-lint-gcf[bot] commented 3 months ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

googleapis / java-bigtable

fix: rate limiting should be ineffective when RateLimitInfo is not present #2243