Closed cushon closed 3 weeks ago
cc @jackdingilian
The use of EqualsTester added in https://github.com/googleapis/java-bigtable/commit/25218e8cc46f9a51d4b6515afdb8931e574b0bb1 is incorrect:
EqualsTester
https://github.com/googleapis/java-bigtable/blob/25218e8cc46f9a51d4b6515afdb8931e574b0bb1/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/common/TypeTest.java#L123-L129
There needs to be a terminal call to testEquals() for the equals tester to do anything, that assertion is not currently being run.
testEquals()
This issue was found by https://errorprone.info/bugpattern/MissingTestCall
cc @jackdingilian
The use of
EqualsTesteradded in https://github.com/googleapis/java-bigtable/commit/25218e8cc46f9a51d4b6515afdb8931e574b0bb1 is incorrect:https://github.com/googleapis/java-bigtable/blob/25218e8cc46f9a51d4b6515afdb8931e574b0bb1/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/common/TypeTest.java#L123-L129
There needs to be a terminal call to
testEquals()for the equals tester to do anything, that assertion is not currently being run.This issue was found by https://errorprone.info/bugpattern/MissingTestCall