search

googleapis / java-bigtable

Apache License 2.0
70 stars 86 forks source link

chore: secure hermetic_library_generation workflow #2317

Closed diegomarquezp closed 1 week ago

diegomarquezp commented 3 weeks ago

Thanks to @diogoteles08 for the inspection on our repos. This PR inlines environment variables to avoid overriding script injections.

JoeWang1127 commented 2 weeks ago

Could you create a forked repo and test whether the workflow will be skipped?

diegomarquezp commented 2 weeks ago

Could you create a forked repo and test whether the workflow will be skipped?

@JoeWang1127 we tried this in https://github.com/googleapis/java-bigtable/pull/2317#discussion_r1731458621. I think we still confirmed it works the other way around: non-forked repos actually get triggered.