googleapis / java-bigtable

Apache License 2.0
71 stars 86 forks source link

chore: simplify sample rows key callable chain #2396

Closed igorbernstein2 closed 1 week ago

igorbernstein2 commented 1 week ago

Previously there were 3 chain creators:

  1. createSampleRowKeysBaseCallable
  2. createSampleRowKeysWithRequestCallable
  3. createSampleRowKeysCallable

The primary reason for this is that SampleRowKeysWithRequest was introduced after createSampleRowKeysCallable because it supports authorized views.

This pr simplifies the logic by moving everything into createSampleRowKeysWithRequestCallable and makes createSampleRowKeysCallable be a tiny shim to convert a String tableId into a SampleRowKeysRequest