search

googleapis / java-logging-logback

Apache License 2.0
42 stars 29 forks source link

Appender default flushlevel is inconsistent with java-logging client's default #1328

Open burkedavison opened 3 months ago

burkedavison commented 3 months ago

The java-logging library updated its flushlevel default to OFF in Dec 2018 due to the performance cost of flushing on the same thread as the application.

However, the java-logging-logback appender was implemented in May 2017 to default to ERROR, and continues to default to ERROR.

( Add'l context: This came to our attention with a request to make Spring Cloud GCP's helper-implementation of a logback appender match the base library's default. See https://github.com/GoogleCloudPlatform/spring-cloud-gcp/issues/2906 for discussion. )

cindy-peng commented 2 weeks ago

Good catch! Thanks for reporting @burkedavison! We will work on a fix here.