googleapis / java-logging

Apache License 2.0
44 stars 37 forks source link

Chore: remove direct dependency on google-cloud-shared-config #1561

Open zhumin8 opened 4 months ago

zhumin8 commented 4 months ago

Regarding this https://github.com/googleapis/java-logging/pull/1550 remove this direct dependency so that this repo only needs sdk-platform-java-config dependency.

cc. @diegomarquezp @blakeli0

diegomarquezp commented 3 months ago

Hi @zhumin8, a couple of quick questions. Should this be part of the current release cycle? Why is google-cloud-shared-config unnecessary compared to sdk-platform-java-config?

cindy-peng commented 1 month ago

Hi @zhumin8, I am also wondering the reason for removing this direct dependency. Could you help us understand why it is unnecessary and it is safe to remove google-cloud-shared-config?