search

googleapis / java-logging

Apache License 2.0
43 stars 39 forks source link

Support CustomWriterIdentity #1647

Open johnclara opened 4 months ago

johnclara commented 4 months ago

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is your feature request related to a problem? Please describe. I think we should be able to set a customWriterIdentity in a CreateSinkRequest. Based on rest api: https://cloud.google.com/logging/docs/reference/v2/rest/v2/organizations.sinks/create

Describe the solution you'd like Allow setting custom writer identity.

Describe alternatives you've considered

Additional context

johnclara commented 3 months ago

@cindy-peng any update on this? Is this on the roadmap or is there a different way to implement this?

cindy-peng commented 1 week ago

Sorry for the late reply @johnclara! I agree that adding CustomWriterIdentity parameter makes sense for the library. Unfortunately the team has been busy working on some other projects. I've added your request to our list and will let you know as soon as we have a plan in place.