search

googleapis / java-shared-config

Shared Maven build configuration for Google Cloud Java client libraries.
Apache License 2.0
19 stars 15 forks source link

chore: fix storage downstream check to use sdk-platform-java-config artifact #759

Closed mpeddada1 closed 6 months ago

mpeddada1 commented 6 months ago

Fixes #748

mpeddada1 commented 6 months ago

downstream/ flatten-pluggin-check running into:

Error: ] Some problems were encountered while processing the POMs:
[FATAL] Non-readable POM /home/runner/work/java-shared-config/java-shared-config/sdk-platform-java/java-storage/pom.xml: no more data available START_DOCUMENT seen <?xml version="1.0" encoding="UTF-8"?>\n... @2:1 @ 
 @ 
Error:  The build could not read 1 project -> [Help 1]

Verifying locally.

[UPDATE] Running mvn install -B -V -ntp -DskipTests=true -Dclirr.skip=true -Denforcer.skip=true -Dmaven.javadoc.skip=true -Dgcloud.download.skip=true -T 1C locally in sdk-platform-java/java-storage results in a successful build:

[INFO] --- maven-install-plugin:2.4:install (default-install) @ google-cloud-storage-control ---
[INFO] Installing /usr/local/google/home/mpeddada/IdeaProjects/java-shared-config/sdk-platform-java/java-storage/google-cloud-storage-control/target/google-cloud-storage-control-2.34.1-alpha-SNAPSHOT.jar to /usr/local/google/home/mpeddada/.m2/repository/com/google/cloud/google-cloud-storage-control/2.34.1-alpha-SNAPSHOT/google-cloud-storage-control-2.34.1-alpha-SNAPSHOT.jar
[INFO] Installing /usr/local/google/home/mpeddada/IdeaProjects/java-shared-config/sdk-platform-java/java-storage/google-cloud-storage-control/pom.xml to /usr/local/google/home/mpeddada/.m2/repository/com/google/cloud/google-cloud-storage-control/2.34.1-alpha-SNAPSHOT/google-cloud-storage-control-2.34.1-alpha-SNAPSHOT.pom
[INFO] Installing /usr/local/google/home/mpeddada/IdeaProjects/java-shared-config/sdk-platform-java/java-storage/google-cloud-storage-control/target/google-cloud-storage-control-2.34.1-alpha-SNAPSHOT-tests.jar to /usr/local/google/home/mpeddada/.m2/repository/com/google/cloud/google-cloud-storage-control/2.34.1-alpha-SNAPSHOT/google-cloud-storage-control-2.34.1-alpha-SNAPSHOT-tests.jar
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Storage Parent 2.34.1-SNAPSHOT ..................... SUCCESS [  2.329 s]
[INFO] proto-google-cloud-storage-v2 2.34.1-alpha-SNAPSHOT  SUCCESS [ 18.569 s]
[INFO] grpc-google-cloud-storage-v2 2.34.1-alpha-SNAPSHOT . SUCCESS [  2.355 s]
[INFO] gapic-google-cloud-storage-v2 2.34.1-alpha-SNAPSHOT  SUCCESS [  8.834 s]
[INFO] Google Cloud Storage 2.34.1-SNAPSHOT ............... SUCCESS [02:11 min]
[INFO] proto-google-cloud-storage-control-v2 2.34.1-alpha-SNAPSHOT SUCCESS [  5.382 s]
[INFO] grpc-google-cloud-storage-control-v2 2.34.1-alpha-SNAPSHOT SUCCESS [  2.809 s]
[INFO] google-cloud-storage-control 2.34.1-alpha-SNAPSHOT . SUCCESS [  4.597 s]
[INFO] Google Cloud Storage BOM 2.34.1-SNAPSHOT ........... SUCCESS [  2.329 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:48 min (Wall Clock)
[INFO] Finished at: 2024-02-22T16:38:58Z
mpeddada1 commented 6 months ago

Running mvn help:effective-pom just after replacing the sdk-platform-java-config is results in the same error as https://github.com/googleapis/java-shared-config/pull/759#issuecomment-1959729209.

Able to reproduce this error locally with REPO_TAG=v2.9.3 ./.kokoro/client-library-check.sh java-storage flatten-plugin. Replacing the version doesn't work on this branch because v2.9.3 still uses java-shared-config.

mpeddada1 commented 6 months ago

Thanks for taking a look @burkedavison! Re-requesting a review since the state of the PR has changed since the last review