Implement downstream check to catch failing dependency updates

googleapis / java-shared-config

Shared Maven build configuration for Google Cloud Java client libraries.

Apache License 2.0

19 stars 15 forks source link

Implement downstream check to catch failing dependency updates #790

Open alicejli opened 6 months ago

alicejli commented 6 months ago

This dependency update: https://github.com/googleapis/java-shared-config/pull/772

caused a downstream failure that was only caught when trying to merge the updated shared-config: https://github.com/googleapis/sdk-platform-java/pull/2571#issuecomment-1997618589

There should be some downstream checks in java-shared-config that can catch these types of failures at the time the dependency update is introduced.

suztomo commented 6 months ago

The checks are there.

It's either

It stopped working correctly (the checks failing to tweak the dependency when building, showing green), or
It didn't catch that specific case https://github.com/googleapis/sdk-platform-java/pull/2571#issuecomment-1997618589 (investigation)

Looking forward to your findings.

burkedavison commented 6 months ago

The compatibility problem occurs only with the two spanner repos.

Our java-shared-config downstream checks perform some second-generation-downstream checking as Tomo showed above (bigtable, bigquery), but we aren't fully exercising the full second-generation downstream check fanout. We could add spanner to this repo's list of checks, though, since we know it has shown unique behavior.

("second generation downstream check" == "grandchild repo check")