Open mpeddada1 opened 1 month ago
This came up in an offline discussion with @burkedavison as part of https://github.com/googleapis/java-shared-config/pull/815.
The downstream / dependencies (11, java-spanner) in the PR was failing with the following error:
downstream / dependencies (11, java-spanner)
[INFO] --- maven-dependency-plugin:3.5.0:analyze (default-cli) @ google-cloud-spanner --- Error: Used undeclared dependencies found: Error: org.graalvm.sdk:nativeimage:jar:24.0.1:provided
However, this dependency is intentionally scoped as provided making this failure a false positive.
provided
Potential Solution: Set the maven-dependency-plugin's ignoreNonCompile parameter to true (https://maven.apache.org/plugins/maven-dependency-plugin/analyze-mojo.html#ignoreNonCompile) to ignore provided scoped dependencies when mvn dependency:analyze is called. The configuration change will likely be at:
ignoreNonCompile
true
mvn dependency:analyze
https://github.com/googleapis/java-shared-config/blob/3c3c6307ea88dc56f5901a95c295d1b2d53a3559/java-shared-config/pom.xml#L144-L158
cc/ @suztomo
I agree with excluding the dependency in the plugin configuration.
This came up in an offline discussion with @burkedavison as part of https://github.com/googleapis/java-shared-config/pull/815.
The
downstream / dependencies (11, java-spanner)
in the PR was failing with the following error:However, this dependency is intentionally scoped as
provided
making this failure a false positive.Potential Solution: Set the maven-dependency-plugin's
ignoreNonCompile
parameter totrue
(https://maven.apache.org/plugins/maven-dependency-plugin/analyze-mojo.html#ignoreNonCompile) to ignoreprovided
scoped dependencies whenmvn dependency:analyze
is called. The configuration change will likely be at:https://github.com/googleapis/java-shared-config/blob/3c3c6307ea88dc56f5901a95c295d1b2d53a3559/java-shared-config/pom.xml#L144-L158
cc/ @suztomo