googleapis / java-shared-config

Shared Maven build configuration for Google Cloud Java client libraries.
Apache License 2.0
19 stars 15 forks source link

fix: address terraform installation failure by updating hashicorp baseurl #881

Closed mpeddada1 closed 2 months ago

mpeddada1 commented 2 months ago

For https://github.com/googleapis/java-shared-config/pull/874

This PR updates the hashicorp baseurl to https://rpm.releases.hashicorp.com/RHEL/8/ to address the following error:

One of the configured repositories failed (Hashicorp Stable - x86_64)
. . .
The command '/bin/sh -c yum -y install terraform' returned a non-zero code: 

According to https://www.hashicorp.com/official-packaging-guide, only RHEL 8 and 9 are supported.

JoeWang1127 commented 2 months ago

LGTM, but I'll leave Burke to give the final approve.

mpeddada1 commented 2 months ago

Thank you both for the review!