Open surbhigarg92 opened 3 months ago
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge
label. Good luck human!
-- conventional-commit-lint bot https://conventionalcommits.org/
nit: please check behaviour of this with emulator env set, ideally it should be noop with emulator
Added a check for skipping enabling metrics for emulator
Can we add a more descriptive pull request title than client metrics
, and also add a description to the pull request? That will improve the release notes that are generated from this change.
If it is something that is not yet GA, but still needs to be merged now, then we should rename the pull request title to chore:...
.
If it is only for testing, can we then use the following trick to make this package-private: Make this package-private Add a public static method to SpannerOptionsTestHelper that takes a SpannerOptions.Builder instance as an argument, and that calls this setEnableBuiltInMetrics(...) method. Call the SpannerOptionsTestHelper method from the tests that need to set this value.
I have actually removed public
from setEnableBuiltInMetrics
. It was only required for ITBuiltinMetricsTest
which we are not enabling right now anyway. Lets not give an option to customers to enable it till the time we actually GA our feature.
This PR adds built-in metrics to the Java client library. This will introduce below metrics for the consumers of this library .
This feature is not currently available for customers to use. Once GA'ed consumers of this library will start getting these metrics in the MetricsExplorer