search

googleapis / java-spanner

Apache License 2.0
53 stars 104 forks source link

build: make executor deps test scoped #3161

Open olavloite opened 1 month ago

olavloite commented 1 month ago

The executor dependencies are not needed for the normal build, but are only used for tests, and should therefore be test scoped.

olavloite commented 1 month ago

@gyang-google Can these dependencies be test-scoped? Or do we need them for a specific reason as a compile dependency, which again also means that they are included in the .jar that we ship to users?

gyang-google commented 1 month ago

Actually we need to build them to .jar targets, but as long as we have a specific way to build them with the client libraries, we are good. Do you have any ideas here?

Best, Guang

On Thu, Jun 13, 2024 at 12:10 AM Knut Olav Løite @.***> wrote:

@gyang-google https://github.com/gyang-google Can these dependencies be test-scoped? Or do we need them for a specific reason as a compile dependency, which again also means that they are included in the .jar that we ship to users?

— Reply to this email directly, view it on GitHub https://github.com/googleapis/java-spanner/pull/3161#issuecomment-2164752486, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALQZFQJH6HTR47TKACQL5OLZHFAV3AVCNFSM6AAAAABJHWZM4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRUG42TENBYGY . You are receiving this because you were mentioned.Message ID: @.***>

gyang-google commented 4 weeks ago

@olavloite please let me know once this check is merged, I need to update the build command accordingly.