googleapis / java-spanner

Apache License 2.0
64 stars 114 forks source link

chore: Update generation configuration at Fri Aug 23 02:16:42 UTC 2024 #3244

Closed cloud-java-bot closed 2 months ago

cloud-java-bot commented 2 months ago

chore: Update generation configuration at Fri Aug 23 02:16:42 UTC 2024

BEGIN_COMMIT_OVERRIDE BEGIN_NESTED_COMMIT feat(spanner): add edition field to the instance proto END_NESTED_COMMIT END_COMMIT_OVERRIDE

generated-files-bot[bot] commented 2 months ago

Warning: This pull request is touching the following templated files:

rahul2393 commented 2 months ago

@diegomarquezp Any idea why all the commits are tagged as chore: here? It's very hard to publish docs changes for features because of this.

diegomarquezp commented 2 months ago

@rahul2393 looks like the generation job has been skipped since this was introduced:

https://github.com/googleapis/java-spanner/blob/30071457ad444b87cea8441a7a35bc24430286f6/.github/workflows/hermetic_library_generation.yaml#L22-L27

We are finishing an approach in bigtable that we will then propagate to all hand-written repos

cc: @blakeli0

diegomarquezp commented 2 months ago

@rahul2393 we have a temporary fix for this

https://github.com/googleapis/java-spanner/pull/3310

This will create proper commit messages in the meantime.