search

googleapis / langchain-google-datastore-python

Apache License 2.0
2 stars 2 forks source link

fix: exclude messages field from Datastore index to avoid 1500 bytes limit #37

Closed cymarechal-devoteam closed 8 months ago

cymarechal-devoteam commented 8 months ago

Hi,

While playing around with DatastoreChatMessageHistory, I noticed that I quickly ran into Datastore's 1,500 bytes limit for indexed string property's UTF-8 encoding (source: https://cloud.google.com/datastore/docs/concepts/limits).

This PR creates a simple test case to demonstrate the issue and solves it by using Datastore's exclude_from_indexes parameter.

Feedback appreciated!

averikitsch commented 8 months ago

/gcbrun

cymarechal-devoteam commented 8 months ago

Hi @averikitsch, Thank you for interacting! I see some integration tests have failed. Is there any way I can help on those?

averikitsch commented 8 months ago

/gcbrun

averikitsch commented 8 months ago

@JU-2094 is currently out of office and will review next week. Thanks!

averikitsch commented 8 months ago

/gcbrun

averikitsch commented 8 months ago

@cymarechal-devoteam can you resolve the merge conflicts?

cymarechal-devoteam commented 8 months ago

@cymarechal-devoteam can you resolve the merge conflicts?

That should be it! Please let me know if there is anything else.

averikitsch commented 8 months ago

/gcbrun