googleapis / nodejs-bigquery

Node.js client for Google Cloud BigQuery: A fast, economical and fully-managed enterprise data warehouse for large-scale data analytics.
https://cloud.google.com/bigquery/
Apache License 2.0
467 stars 211 forks source link

Simplify `query` methods to return just `QueryRowsResponse` #1400

Open alvarowolfx opened 2 months ago

alvarowolfx commented 2 months ago

For the type returned by the query method, for historical/backward compatibility reasons, the method signature shows that it can return both a Promise<QueryRowsResponse> (which has 3 positional parameters) or Promise<SimpleQueryRowsResponse (which has only 2).

Ideally we should only return QueryRowsResponse and remove any reference to SimpleQueryRowsResponse. This is going to be a breaking change, so we should schedule this for the next major node upgrade release.