Types missing on bigquery.query => bigquery.ITableDataList

googleapis / nodejs-bigquery

Node.js client for Google Cloud BigQuery: A fast, economical and fully-managed enterprise data warehouse for large-scale data analytics.

https://cloud.google.com/bigquery/

Apache License 2.0

467 stars 211 forks source link

Types missing on bigquery.query => bigquery.ITableDataList #931

Closed skrrriiieeet closed 3 years ago

skrrriiieeet commented 3 years ago

There are keys that are being returned when calling bigquery.query that doesn't exist on the typescript interface. Eg. schema is being returned when I call bigquery.query(query, { maxResults: 1 }) but it doesn't exist on the type bigquery.ITableDataList.

Environment details

Node.js version: 14.5.4
@google-cloud/bigquery version: 5.5.0

Steps to reproduce

const queryResponse = await bigquery.query(query, { maxResults: 1 })

Capture

Capture2

syJSdev commented 3 years ago

I think this bug happens on v5.5.0. but fixed on v5.6.1. Why don't you release v5.6.1 to npm? @steffnay The document is updated but npm is not. https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs/getQueryResults

steffnay commented 3 years ago

5.7.0 is on npm, so this should be fixed now!