search

googleapis / nodejs-common

🚀🐢 A set of classes and utilities used in Google npm modules.
Apache License 2.0
58 stars 35 forks source link

fix: replace `ent` with `html-entities` #813

Closed Drarig29 closed 6 months ago

Drarig29 commented 7 months ago

Fixes #812

This PR replaces ent with html-entities.

BEGIN_COMMIT_OVERRIDE fix: replace ent with html-entities Release-As: 5.0.2 END_COMMIT_OVERRIDE

google-cla[bot] commented 7 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

sofisl commented 6 months ago

Unfortunately we can't accommodate this request because Node 18 is required for this package, and we're on Node 14. If there's another dependency that would do the trick that supports Node 14, that would work. Or, we can wait until our work to upgrade to Node 16, which should be in the next few months.

Drarig29 commented 6 months ago

@sofisl html-entities has zero dependencies.

The error actually comes from one of the devDependencies in this repository: https://github.com/googleapis/nodejs-common/blob/926235906e59324e100c07c7aae4175a7d0255e0/package.json#L46

I have the same error on the main branch if I run the same command as in the CI on Node 16:

npm install --production --engine-strict --ignore-scripts --no-package-lock

So the issue doesn't come from the PR

Drarig29 commented 6 months ago

@sofisl here is a PR to fix the bug: https://github.com/googleapis/nodejs-common/pull/814