search

googleapis / nodejs-kms

This repository is deprecated. All of its content and history has been moved to googleapis/google-cloud-node.
https://cloud.google.com/kms/
Apache License 2.0
56 stars 25 forks source link

Support for asymmetric sign #239

Closed raman-nbg closed 4 years ago

raman-nbg commented 4 years ago

Currently the nodjs client library does not support using KMS asymmetric signing.

https://cloud.google.com/kms/docs/reference/rpc/google.cloud.kms.v1#google.cloud.kms.v1.AsymmetricSignRequest

Are there any plans to support this feature?

raman-nbg commented 4 years ago

It seems like that this feature is already implemented, but not tested or documented.

Is this feature already safe to use?

bcoe commented 4 years ago

@raman-nbg our libraries are largely auto-generated, and the upstream KMS library is a v1 API.

All this is to say, yes this feature is safe to use :+1:

We should definitely consider adding a sample for it CC: @jkwlui.

raman-nbg commented 4 years ago

Thank you for adding an example. The exported types also do not contain a definition for asymmetricSign(): https://www.npmjs.com/package/@types/google-cloud__kms

Of course I can use this by type casting to any. But this makes it hard to use this with TypeScript.

bcoe commented 4 years ago

@raman-nbg these types are not part of this project, and I believe are community contributed. We are in the process of converting our libraries to TypeScript (@alexander-fenster perhaps we could prioritize KMS?) at which point the types for asymmetricSign will be available.