search

googleapis / nodejs-logging-bunyan

Node.js client integration between Stackdriver Logging and Bunyan.
https://cloud.google.com/logging/
Apache License 2.0
63 stars 34 forks source link

System tests are flaky #405

Closed JustinBeckwith closed 3 years ago

JustinBeckwith commented 4 years ago

The changes in https://github.com/googleapis/nodejs-logging-bunyan/pull/404 should not have an effect on the system tests.

DominicKramer commented 4 years ago

It looks like the system tests are failing with

Error: 8 RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Read requests' and limit 'Read requests per minute' of service 'logging.googleapis.com' for consumer 'project_number:1046198160504'.

Because of that, this may not be an issue in this repo itself.

@JustinBeckwith is the quota shared between logging, logging-bunyan, and logging-winston? Also, is there a way to increase the quota?

JustinBeckwith commented 4 years ago

They are very likely sharing quota, yes. On an increase - of course we can! Let me start a thread.

DominicKramer commented 4 years ago

Cool thanks.

bcoe commented 4 years ago

see:


  1) LoggingBunyan
       should properly write log entries:
     Error: Timeout of 90000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/tmpfs/src/github/nodejs-logging-bunyan/build/system-test/logging-bunyan.js)

It might be worth talking to @stephenplusplus about some refactoring he's done related to cleaning up log entries.

JustinBeckwith commented 4 years ago

Today it was:

 1) LoggingBunyan
       ErrorReporting
         reports errors when logging errors:
     Error: Timeout of 90000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/tmpfs/src/github/nodejs-logging-bunyan/build/system-test/logging-bunyan.js)
0xSage commented 3 years ago

I'll take a look at this shortly.

Today it was : 

[09:22:12][ERROR] Failed to get build config
com.google.devtools.kokoro.config.ConfigException: Couldn't find build configuration file system-test.cfg or system-test.gcl under /tmp/workspace/workspace/cloud-devrel/client-libraries/nodejs/presubmit/googleapis/nodejs-logging-bunyan/node10/system-test/src/github/nodejs-logging-bunyan/.kokoro/presubmit/node10.

failing on both presubmit systems and sample tests

0xSage commented 3 years ago

resolved with Critique CL