search

googleapis / nodejs-logging-bunyan

Node.js client integration between Stackdriver Logging and Bunyan.
https://cloud.google.com/logging/
Apache License 2.0
63 stars 34 forks source link

Export types #411

Closed majelbstoat closed 4 years ago

majelbstoat commented 4 years ago

/src/core.d.ts helpfully has Typescript types for things like BunyanLog and HTTPRequest. Unfortunately, even though they're imported into index.d.ts, they're not exported, which means we can't use them for strong typing in userland.

Would you consider exporting types so we don't have to redefine them?

majelbstoat commented 4 years ago

... and not 10 minutes later I realised I could do this:

import { BunyanLogRecord, HttpRequest } from '@google-cloud/logging-bunyan/build/src/types/core'