googleapis / nodejs-logging-bunyan

Node.js client integration between Stackdriver Logging and Bunyan.
https://cloud.google.com/logging/
Apache License 2.0
63 stars 34 forks source link

feat: added optional opentelemetry tracer logging #482

Closed davearata-snorack closed 3 years ago

davearata-snorack commented 4 years ago

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes #448 🦕

google-cla[bot] commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

codecov[bot] commented 4 years ago

Codecov Report

Merging #482 (a0b0fce) into master (70cd619) will increase coverage by 0.10%. The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
+ Coverage   93.56%   93.66%   +0.10%     
==========================================
  Files           4        4              
  Lines         497      537      +40     
  Branches       36       45       +9     
==========================================
+ Hits          465      503      +38     
- Misses         32       34       +2     
Impacted Files Coverage Δ
src/index.ts 97.96% <95.23%> (-0.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 70cd619...a0b0fce. Read the comment docs.

google-cla[bot] commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

davearata-snorack commented 4 years ago

@googlebot I signed it!

0xSage commented 3 years ago

@davearata-snorack can you edit your PR title per conventional commit semantics? The reason that's important is that this repo does auto release based on the types of changes committed for release.

0xSage commented 3 years ago

@davearata-snorack can you resolve conflicts in package.json? Drafting this PR in the meantime

0xSage commented 3 years ago

FYI, traceparent detection was implemented upstream in nodejs-logging here. Closing this PR as it's not needed for now - but feel free to reopen as the upstream impl was low level and we can always add additional otel support within this library.