search

googleapis / nodejs-logging-bunyan

Node.js client integration between Stackdriver Logging and Bunyan.
https://cloud.google.com/logging/
Apache License 2.0
63 stars 34 forks source link

docs: reverts cloud logging language in a couple places #493

Closed yoshi-automation closed 3 years ago

yoshi-automation commented 3 years ago

This PR was generated using Autosynth. :rainbow:

Synth log will be available here: https://source.cloud.google.com/results/invocations/439975d5-a04c-464c-99f2-a44779725d38/targets

codecov[bot] commented 3 years ago

Codecov Report

Merging #493 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #493   +/-   ##
=======================================
  Coverage   93.56%   93.56%           
=======================================
  Files           4        4           
  Lines         497      497           
  Branches       36       39    +3     
=======================================
  Hits          465      465           
  Misses         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa26e36...dc6a2cc. Read the comment docs.

bcoe commented 3 years ago

@simonz130 the removal of stackdriver language is being reverted, due to the language still remaining, here:

https://github.com/googleapis/nodejs-logging-bunyan/blob/master/.readme-partials.yml

and, here:

https://github.com/googleapis/nodejs-logging-bunyan/blob/master/samples/quickstart.js#L26

0xSage commented 3 years ago

Closing this PR in favor of #500