googleapis / nodejs-logging-bunyan

Node.js client integration between Stackdriver Logging and Bunyan.
https://cloud.google.com/logging/
Apache License 2.0
63 stars 34 forks source link

express middleware global logger: should properly write log entries failed #696

Closed flaky-bot[bot] closed 11 months ago

flaky-bot[bot] commented 1 year ago

Note: #656 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: 7ffcae5c9fb2a0e57bcc8eb308af543343cdbe04 buildURL: Build Status, Sponge status: failed

Test output
Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/workspace/build/system-test/test-middleware-express.js)
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/workspace/build/system-test/test-middleware-express.js)
    at listOnTimeout (internal/timers.js:554:17)
    at processTimers (internal/timers.js:497:7)
flaky-bot[bot] commented 1 year ago

Looks like this issue is flaky. :worried:

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (7ffcae5c9fb2a0e57bcc8eb308af543343cdbe04), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

cindy-peng commented 11 months ago

We have upgraded node version to 14 since Aug 10th: https://github.com/googleapis/nodejs-logging-bunyan/pull/705/files#diff-0186f53b45e19984a47319509fec85f490eeeb4a081867434ee4b8abfe438912

system-test on node12 has been deprecated already: https://fusion2.corp.google.com/invocations?q=target:cloud-devrel%2Fclient-libraries%2Fnodejs%2Fnightly%2Fgoogleapis%2Fnodejs-logging-bunyan%2Fnode12%2Fsystem-test

system-test on nodoe 14 has been passing for last 60 days: https://fusion2.corp.google.com/invocations;page_size=25;offset=0?q=target:cloud-devrel%2Fclient-libraries%2Fnodejs%2Fnightly%2Fgoogleapis%2Fnodejs-logging-bunyan%2Fnode14%2Fsystem-test