Closed domdomegg closed 1 year ago
Thanks @domdomegg for opening this issue and sorry for inconvenience. I believe this issue was addressed in 732 - please let me know if that resolves the matter.
I think that resolves the issue with making the request.
However, I think there's still some issue in the API that it times out rather than returning a 400 or similar. It also might be useful to include in the documentation instructions about this, given a few people have gotten stuck here.
The actual problem happens during protobuf encoding stage, so due to error the request is never sent... But I agree with you @domdomegg - the timeout is absolutely not a proper behavior. I opened an issue 1376 to track this problem and going to close this one - please let me know if you have any more concerns.
Thanks, happy to track there :+1:
1) Is this a client library issue or a product issue?
Unclear, possibly the root cause is a product issue but the client should probably be able to handle this better.
2) Did someone already solve this?
Have reviewed the suggested resources, and don't think this has already been solved.
3) Do you have a support contract?
No.
Environment details
@google-cloud/logging-winston
version: 5.3.0Steps to reproduce
Set up a winston logging client
Log with httpRequest data with a latency property (which should be a string according to https://cloud.google.com/logging/docs/reference/v2/rest/v2/LogEntry#HttpRequest ):
NB: logging requestMethod (string), requestUrl (string), status (number), userAgent (string), remoteIp (string), serverIp (string), referer (string) all seem fine.
Desired behaviour
Ideal: All the logs are sent to Google Cloud Logging correctly.
Better than now: The logs that don't have httpRequest properties on them are at least sent correctly. The logs should be independent - if one fails, that doesn't mean I want to give up on storing all my logs.