search

googleapis / nodejs-logging-winston

Node.js client integration between Stackdriver Logging and Winston.
https://cloud.google.com/logging/
Apache License 2.0
105 stars 50 forks source link

/workspace/build/system-test/test-middleware-express.js global logger: should properly write log entries failed #810

Closed flaky-bot[bot] closed 7 months ago

flaky-bot[bot] commented 1 year ago

Note: #773 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

commit: 7779088ec7a4aab1910200297878ce56e1f7abe1 buildURL: Build Status, Sponge status: failed

Test output
Expected values to be strictly equal:

0 !== 1

      + expected - actual

      -0
      +1

/workspace/system-test/test-middleware-express.ts:52
      assert.strictEqual(entries.length, 1);
             ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

0 !== 1

    at Context. (system-test/test-middleware-express.ts:52:14)
flaky-bot[bot] commented 1 year ago

Looks like this issue is flaky. :worried:

I'm going to leave this open and stop commenting.

A human should fix and close this.

When run at the same commit (7779088ec7a4aab1910200297878ce56e1f7abe1), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

cindy-peng commented 7 months ago

Flaky tests. Tests have been passing for last 20 days: https://fusion2.corp.google.com/invocations?q=target:github%2Fnodejs-logging-winston https://fusion2.corp.google.com/invocations?q=target:cloud-devrel%2Fclient-libraries%2Fnodejs%2Fnightly%2Fgoogleapis%2Fnodejs-logging-winston%2Fnode14%2Fsystem-test