googleapis / nodejs-logging-winston

Node.js client integration between Stackdriver Logging and Winston.
https://cloud.google.com/logging/
Apache License 2.0
105 stars 50 forks source link

fix: skip writing RequestLogEntry for Cloud Run with flag enabled #821

Closed cindy-peng closed 10 months ago

cindy-peng commented 10 months ago

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes #795 🦕

This is a fix similar to the fix in nodejs-logging-bunyan to skip writting parent request log entries for cloud run.

To avoid breaking changes on the existing applications on Cloud Run, we introduce a optional parameter "skipParentEntryForCloudRun" to control the behavior. Right now the default behavior is still to create an request log entry unless "skipParentEntryForCloudRun" is set to be true specifically. We can change the default behavior in the next major release.

generated-files-bot[bot] commented 10 months ago

Warning: This pull request is touching the following templated files: