googleapis / nodejs-logging-winston

Node.js client integration between Stackdriver Logging and Winston.
https://cloud.google.com/logging/
Apache License 2.0
105 stars 50 forks source link

doc: fix link to be grpc link for HttpRequest #828

Closed cindy-peng closed 9 months ago

cindy-peng commented 9 months ago

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes #799 🦕 Logging client library calls gRPC logging API instead of rest. This is to fix the documentation link for HttpRequest message to be correct gRPC link.

generated-files-bot[bot] commented 9 months ago

Warning: This pull request is touching the following templated files:

gkevinzheng commented 9 months ago

I saw in some of the code comments links to the documentation of the JSON HttpRequest object. Could you update those code comments as well, for consistency?

cindy-peng commented 9 months ago

I saw in some of the code comments links to the documentation of the JSON HttpRequest object. Could you update those code comments as well, for consistency?

Good catch! Updated links in code comments as well.