Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
[x] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
[x] Ensure the tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)
Fixes #802 🦕
This is to fix the expected type and value for trace_sampled to be consistent with the documentation. According to the LogEntry API documentation, trace_sampled is expected to be a bool type. This has also been correctly documented in the logging-winston homepage.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #802 🦕 This is to fix the expected type and value for
trace_sampledto be consistent with the documentation. According to the LogEntry API documentation,trace_sampledis expected to be abooltype. This has also been correctly documented in the logging-winston homepage.