search

googleapis / nodejs-logging

Node.js client for Stackdriver Logging: Store, search, analyze, monitor, and alert on log data and events from Google Cloud Platform and Amazon Web Services (AWS).
https://cloud.google.com/logging/
Apache License 2.0
168 stars 99 forks source link

HttpRequest util and express middleware fields #1238

Open galaxyfeeder opened 2 years ago

galaxyfeeder commented 2 years ago

I've just installed the express middleware provided and I've seen that there are some fields that are not mapped between the express Request/Response and the HttpRequest of the LogEntry.

I would like to know if there is any reason why the remoteIp and requestSize are not parsed from requests objects, if there is any specific reason.

remoteIp can be obtained from req.ip as stated here. requestSize can be obtained from requests headers in the same way that is done for the responseSize.

cindy-peng commented 6 months ago

Hi @galaxyfeeder, are you still running into this issue? If so, do you mind sharing an example so I can try repro?

cindy-peng commented 3 weeks ago

Hi @galaxyfeeder, if you are still running into this and feel it is import to add those fields, let us know and we will work on it. Thanks!