Closed cindy-peng closed 1 month ago
Could you put the changes in
protos/
in a separate PR? Not sure how related they are to the current changes.
Yea I was trying to remove these as well, but it looks like owlbot committed this automatically to this PR after I removed them: https://github.com/googleapis/nodejs-logging/commit/c25466975361fabd0b9434be6e50f8d624fffbee
Could you put the changes in
protos/
in a separate PR? Not sure how related they are to the current changes.Yea I was trying to remove these as well, but it looks like owlbot committed this automatically to this PR after I removed them: c254669
Removed proto changes.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1490 🦕
This change is to add OpenTelemetry support for nodejs-logging library and fix trace-span correlation issue. More context about this change: https://b.corp.google.com/issues/270985947
Here are the overall and nodejs-logging design doc for this change: go/logging-otel-span-support go/logging-otel-span-support-nodejs