googleapis / nodejs-logging

Node.js client for Stackdriver Logging: Store, search, analyze, monitor, and alert on log data and events from Google Cloud Platform and Amazon Web Services (AWS).
https://cloud.google.com/logging/
Apache License 2.0
173 stars 63 forks source link

fix: fix interface method not implemented error #1511

Closed cindy-peng closed 4 months ago

cindy-peng commented 5 months ago

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes # 🦕

Patch new version of otel sdk-node-base to fix testing error: https://github.com/googleapis/nodejs-logging/actions/runs/9406112066/job/26039251647?pr=1507

New Addlink, Addlinks methods were added to sdk-node-base package last month: https://github.com/open-telemetry/opentelemetry-js/commit/c503ff1394aac214b5721a0d6a72aaebcfca46f2