Open drunkcod opened 3 weeks ago
I suspect the issue originates here: https://github.com/googleapis/nodejs-logging/blob/9d1d480406c4d1526c8a7fafd9b18379c0c7fcea/src/log-sync.ts#L446
And that doing entry.toJSON({ removeCircular: true });
is one possible solution.
Or perhaps log the serialization issue and shunt it over to the client to de-circularize but swallowing the issue seems no good.
Environment details
@google-cloud/logging
version: 11.2 (via logging-winston 6.0.0)Steps to reproduce
The below will using a plain console transport log an error. With the LoggingWinston transport on the other hand the error will be silent.
This is extra problematic due to a common error AxiosError having a circular dependency and hence such failures are omitted from production logs.