googleapis / nodejs-proto-files

All of the Google API's protocol buffer files
Apache License 2.0
76 stars 18 forks source link

what's the frequency of update of the proto files corpus? #340

Closed proppy closed 3 years ago

proppy commented 3 years ago

It seems that the latest version (2.4.0) is not in sync with https://github.com/googleapis/googleapis

See below:

๐ŸŠ (cd googleapis && git log -1 --oneline)
9a9e29627 (HEAD -> master, origin/master, origin/HEAD) feat: Add fields for Pub/Sub triggers
๐Ÿก cat node_modules/google-proto-files/package.json  | grep version
  "version": "2.4.0",
๐ŸŠ diff -Nru node_modules/google-proto-files/google/home/graph/v1/homegraph.proto googleapis/google/home/graph/v1/homegraph.proto 
--- node_modules/google-proto-files/google/home/graph/v1/homegraph.proto    1985-10-26 17:15:00.000000000 +0900
+++ googleapis/google/home/graph/v1/homegraph.proto 2021-04-15 21:45:00.313406274 +0900
@@ -194,10 +194,11 @@
   // Required. Third-party user ID.
   string agent_user_id = 2 [(google.api.field_behavior) = REQUIRED];

-  // Token to maintain state in the follow up notification response.
-  // Deprecated. See the [notifications
-  // guide](https://developers.google.com/assistant/smarthome/develop/notifications)
-  // for details on implementing follow up notifications.
+  // Deprecated.
+  // (-- Token to maintain state in the follow up notification response. See the
+  // notifications guide at
+  // https://developers.google.com/assistant/smarthome/develop/notifications for
+  // details on implementing follow up notifications --)
   string follow_up_token = 5 [deprecated = true];

   // Required. State of devices to update and notification metadata for devices.
๐Ÿ‘บ 

Should we clarify the frequency of update in the README.md file?

alexander-fenster commented 3 years ago

It's indeed not in sync. We do update it as needed.

@proppy Can you share your use case with this package? Is there any specific reason why you're using it and not the @google-cloud/* client libraries (that also have protos included)?

alexander-fenster commented 3 years ago

@summer-ji-eng Let's schedule some time to update the protos in this package.

proppy commented 3 years ago

@alexander-fenster as it also includes non-cloud APIs (like https://source.corp.google.com/piper///depot/google3/google/home/graph/v1/homegraph.proto), it's possibly used by developers willing to gain enhanced performance/optimize resource consumption over the generic Node.js client: https://github.com/googleapis/google-auth-library-nodejs

See https://stackoverflow.com/questions/67113632/how-to-call-the-home-graph-api-with-grpc-on-node-js

hkdevandla commented 3 years ago

did we update the protos @alexander-fenster @summer-ji-eng ? what are the next steps here?

alexander-fenster commented 3 years ago

We did it two days ago, the latest release 2.5.0 contains the recent protos. @summer-ji-eng We need to setup a process of regular proto updates, maybe monthly will work. In the normal case, it's just an empty feat: PR (git checkout -b update && git commit --allow-empty -m 'feat: update protos' && git push origin update) and then a release.