googleapis / nodejs-proto-files

All of the Google API's protocol buffer files
Apache License 2.0
76 stars 18 forks source link

loadSync: should not be able to load test file using protobufjs directly failed #447

Closed flaky-bot[bot] closed 1 year ago

flaky-bot[bot] commented 1 year ago

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and I will stop commenting.


commit: 393f6caae049827ce31a3fff0ee10437735a72e3 buildURL: Build Status, Sponge status: failed

Test output
ENOENT: no such file or directory, open '/workspace/test/fixtures/google/api/annotations.proto'
Error: ENOENT: no such file or directory, open '/workspace/test/fixtures/google/api/annotations.proto'
    at Object.openSync (fs.js:462:3)
    at Object.readFileSync (fs.js:364:35)
    at fetch (node_modules/protobufjs/src/root.js:172:34)
    at process (node_modules/protobufjs/src/root.js:133:29)
    at fetch (node_modules/protobufjs/src/root.js:178:13)
    at Root.load (node_modules/protobufjs/src/root.js:206:13)
    at Root.loadSync (node_modules/protobufjs/src/root.js:247:17)
    at Object.loadSync (node_modules/protobufjs/src/index-light.js:69:17)
    at Context. (build/test/load.test.js:53:31)
        -> /workspace/test/load.test.ts:67:27
    at processImmediate (internal/timers.js:461:21)
bcoe commented 1 year ago

Fixed by:

https://github.com/googleapis/nodejs-proto-files/pull/448