googleapis / nodejs-pubsub

Node.js client for Google Cloud Pub/Sub: Ingest event streams from anywhere, at any scale, for simple, reliable, real-time stream analytics.
https://cloud.google.com/pubsub/
Apache License 2.0
518 stars 230 forks source link

fix(deps): update dependency @opentelemetry/semantic-conventions to ~1.16.0 #1821

Closed renovate-bot closed 11 months ago

renovate-bot commented 11 months ago

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@opentelemetry/semantic-conventions (source) ~1.3.0 -> ~1.16.0 age adoption passing confidence

Release Notes

open-telemetry/opentelemetry-js (@​opentelemetry/semantic-conventions) ### [`v1.16.0`](https://togithub.com/open-telemetry/opentelemetry-js/blob/HEAD/CHANGELOG.md#1160) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-js/compare/v1.15.2...v1.16.0) ##### :rocket: (Enhancement) - feat(sdk-metrics): implement MetricProducer specification [#​4007](https://togithub.com/open-telemetry/opentelemetry-js/pull/4007) - feat: update PeriodicExportingMetricReader and PrometheusExporter to accept optional metric producers [#​4077](https://togithub.com/open-telemetry/opentelemetry-js/pull/4077) [@​aabmass](https://togithub.com/aabmass) ##### :bug: (Bug Fix) - fix(exporter-zipkin): rounding duration to the nearest int to be compliant with zipkin protocol [#​4064](https://togithub.com/open-telemetry/opentelemetry-js/pull/4064) [@​n0cloud](https://togithub.com/n0cloud) - fix(sdk-metrics): metric names should be case-insensitive ##### :books: (Refine Doc) - docs(guidelines): add dependencies guidelines [#​4040](https://togithub.com/open-telemetry/opentelemetry-js/pull/4040) ### [`v1.15.2`](https://togithub.com/open-telemetry/opentelemetry-js/blob/HEAD/CHANGELOG.md#1152) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-js/compare/v1.15.1...v1.15.2) ##### :bug: (Bug Fix) - fix(core): stop rounding to nearest int in hrTimeTo\*seconds() functions [#​4014](https://togithub.com/open-telemetry/opentelemetry-js/pull/4014/) [@​aabmass](https://togithub.com/aabmass) - fix(sdk-metrics): ignore invalid metric values [#​3988](https://togithub.com/open-telemetry/opentelemetry-js/pull/3988) [@​legendecas](https://togithub.com/legendecas) - fix(core): add baggage support for values containing an equals sign [#​3975](https://togithub.com/open-telemetry/opentelemetry-js/pull/3975) [@​krosenk729](https://togithub.com/krosenk729) ### [`v1.15.1`](https://togithub.com/open-telemetry/opentelemetry-js/blob/HEAD/CHANGELOG.md#1151) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-js/compare/v1.15.0...v1.15.1) ##### :bug: (Bug Fix) - Revert "feat(minification): Add noEmitHelpers, importHelpers and tslib as a dependency ([#​3914](https://togithub.com/open-telemetry/opentelemetry-js/issues/3914))" [#​4011](https://togithub.com/open-telemetry/opentelemetry-js/pull/4011) [@​dyladan](https://togithub.com/dyladan) ### [`v1.15.0`](https://togithub.com/open-telemetry/opentelemetry-js/blob/HEAD/CHANGELOG.md#1150) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-js/compare/v1.14.0...v1.15.0) ##### :bug: (Bug Fix) - fix(opentelemetry-exporter-prometheus): Update default PrometheusExporter to not append a timestamp to match the text based exposition format [#​3961](https://togithub.com/open-telemetry/opentelemetry-js/pull/3961) [@​JacksonWeber](https://togithub.com/JacksonWeber) - fix(sdk-metrics): Update default Histogram's boundary to match OTEL's spec [#​3893](https://togithub.com/open-telemetry/opentelemetry-js/pull/3893/) [@​chigia001](https://togithub.com/chigia001) - fix(sdk-metrics): preserve startTime for cumulative ExponentialHistograms [#​3934](https://togithub.com/open-telemetry/opentelemetry-js/pull/3934/) [@​aabmass](https://togithub.com/aabmass) - fix(sdk-trace-web): add secureConnectionStart to https only [#​3879](https://togithub.com/open-telemetry/opentelemetry-js/pull/3879) [@​Abinet18](https://togithub.com/Abinet18) ##### :house: (Internal) - feat(minification): \[Minification] Add noEmitHelpers, importHelpers and tslib as a dependency [#​3913](https://togithub.com/open-telemetry/opentelemetry-js/issues/3913) [@​MSNev](https://togithub.com/MSNev) ### [`v1.14.0`](https://togithub.com/open-telemetry/opentelemetry-js/blob/HEAD/CHANGELOG.md#1140) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-js/compare/v1.13.0...v1.14.0) ##### :rocket: (Enhancement) - feat(SpanExporter): Add optional forceFlush to SpanExporter interface [#​3753](https://togithub.com/open-telemetry/opentelemetry-js/pull/3753/) [@​sgracias1](https://togithub.com/sgracias1) [@​JacksonWeber](https://togithub.com/JacksonWeber) ### [`v1.13.0`](https://togithub.com/open-telemetry/opentelemetry-js/blob/HEAD/CHANGELOG.md#1130) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-js/compare/v1.12.0...v1.13.0) ##### :rocket: (Enhancement) - feat(core): add environment variables for OTLP log exporters. [#​3712](https://togithub.com/open-telemetry/opentelemetry-js/pull/3712/) [@​llc1123](https://togithub.com/llc1123) ##### :bug: (Bug Fix) - fix(http-instrumentation): stop listening to `request`'s `close` event once it has emitted `response` [#​3625](https://togithub.com/open-telemetry/opentelemetry-js/pull/3625) [@​SimenB](https://togithub.com/SimenB) - fix(sdk-node): fix initialization in bundled environments by not loading [@​opentelemetry/exporter-jaeger](https://togithub.com/opentelemetry/exporter-jaeger) [#​3739](https://togithub.com/open-telemetry/opentelemetry-js/pull/3739) [@​pichlermarc](https://togithub.com/pichlermarc) ### [`v1.12.0`](https://togithub.com/open-telemetry/opentelemetry-js/blob/HEAD/CHANGELOG.md#1120) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-js/compare/v1.11.0...v1.12.0) ##### :rocket: (Enhancement) - feat(tracing): log span name and IDs when span end is called multiple times [#​3716](https://togithub.com/open-telemetry/opentelemetry-js/pull/3716) - feat(core): add logs environment variables; add timeout utils method. [#​3549](https://togithub.com/open-telemetry/opentelemetry-js/pull/3549/) [@​fuaiyi](https://togithub.com/fuaiyi) ##### :bug: (Bug Fix) - fix(instrumentation-http): fixed description for http.server.duration metric [#​3710](https://togithub.com/open-telemetry/opentelemetry-js/pull/3710) - fix(opentelemetry-sdk-trace-web): don't crash in runtimes where location isn't defined [#​3715](https://togithub.com/open-telemetry/opentelemetry-js/pull/3715) ### [`v1.11.0`](https://togithub.com/open-telemetry/opentelemetry-js/blob/HEAD/CHANGELOG.md#1110) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-js/compare/v1.10.1...v1.11.0) ##### :rocket: (Enhancement) - feat(sdk-metrics): add exponential histogram support [#​3505](https://togithub.com/open-telemetry/opentelemetry-js/pull/3505), [#​3506](https://togithub.com/open-telemetry/opentelemetry-js/pull/3506) [@​mwear](https://togithub.com/mwear) - feat(resources): collect additional process attributes [#​3605](https://togithub.com/open-telemetry/opentelemetry-js/pull/3605) [@​mwear](https://togithub.com/mwear) ##### :bug: (Bug Fix) - fix(sdk-metrics): merge uncollected delta accumulations [#​3667](https://togithub.com/open-telemetry/opentelemetry-js/pull/3667) [@​legendecas](https://togithub.com/legendecas) - fix(sdk-trace-web): make `parseUrl()` respect document.baseURI [#​3670](https://togithub.com/open-telemetry/opentelemetry-js/pull/3670) [@​domasx2](https://togithub.com/domasx2) ##### :books: (Refine Doc) - doc(sdk): update NodeSDK example [#​3684](https://togithub.com/open-telemetry/opentelemetry-js/pull/3684) [@​martinkuba](https://togithub.com/martinkuba) - docs: change vmarchaud status from maintainer to emeritus [#​3710](https://togithub.com/open-telemetry/opentelemetry-js/pull/3710) [@​vmarchaud](https://togithub.com/vmarchaud) - docs: change rauno56 status from maintainer to emeritus [#​3706](https://togithub.com/open-telemetry/opentelemetry-js/pull/3706) [@​rauno56](https://togithub.com/rauno56) ### [`v1.10.1`](https://togithub.com/open-telemetry/opentelemetry-js/blob/HEAD/CHANGELOG.md#1101) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-js/compare/v1.10.0...v1.10.1) ##### :bug: (Bug Fix) - fix(resource): make properties for async resource resolution optional [#​3677](https://togithub.com/open-telemetry/opentelemetry-js/pull/3677) [@​pichlermarc](https://togithub.com/pichlermarc) - fix(resource): change fs/promises import to be node 12 compatible [#​3681](https://togithub.com/open-telemetry/opentelemetry-js/pull/3681) [@​pichlermarc](https://togithub.com/pichlermarc) ### [`v1.10.0`](https://togithub.com/open-telemetry/opentelemetry-js/blob/HEAD/CHANGELOG.md#1100) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-js/compare/v1.9.1...v1.10.0) ##### :rocket: (Enhancement) - feat(resource): create sync resource with some attributes that resolve asynchronously [#​3460](https://togithub.com/open-telemetry/opentelemetry-js/pull/3460) [@​samimusallam](https://togithub.com/samimusallam) - feat: collect host id for non-cloud environments [#​3575](https://togithub.com/open-telemetry/opentelemetry-js/pull/3575) [@​mwear](https://togithub.com/mwear) - feat (api-logs): separate Events API into its own package [3550](https://togithub.com/open-telemetry/opentelemetry-js/pull/3550) [@​martinkuba](https://togithub.com/martinkuba) - feat(sdk-metrics): apply binary search in histogram recording [#​3539](https://togithub.com/open-telemetry/opentelemetry-js/pull/3539) [@​legendecas](https://togithub.com/legendecas) - perf(propagator-jaeger): improve deserializeSpanContext performance [#​3541](https://togithub.com/open-telemetry/opentelemetry-js/pull/3541) [@​doochik](https://togithub.com/doochik) - feat: support TraceState in SamplingResult [#​3530](https://togithub.com/open-telemetry/opentelemetry-js/pull/3530) [@​raphael-theriault-swi](https://togithub.com/raphael-theriault-swi) - feat(sdk-trace-base): add diagnostic logging when spans are dropped [#​3610](https://togithub.com/open-telemetry/opentelemetry-js/pull/3610) [@​neoeinstein](https://togithub.com/neoeinstein) - feat: add unit to view instrument selection criteria [#​3647](https://togithub.com/open-telemetry/opentelemetry-js/pull/3647) [@​jlabatut](https://togithub.com/jlabatut) - feat(tracing): expose dropped counts for attributes, events and links on span [#​3576](https://togithub.com/open-telemetry/opentelemetry-js/pull/3576) [@​mohitk05](https://togithub.com/mohitk05) ##### :bug: (Bug Fix) - fix(core): added falsy check to make otel core work with browser where webpack config had process as false or null [#​3613](https://togithub.com/open-telemetry/opentelemetry-js/issues/3613) [@​ravindra-dyte](https://togithub.com/ravindra-dyte) - fix(instrumentation-http): include query params in http.target [#​3646](https://togithub.com/open-telemetry/opentelemetry-js/pull/3646) [@​kobi-co](https://togithub.com/kobi-co) ##### :books: (Refine Doc) - chore: update http example [#​3651](https://togithub.com/open-telemetry/opentelemetry-js/pull/3651) [@​JamieDanielson](https://togithub.com/JamieDanielson) ##### :house: (Internal) - chore(exporter-jaeger): deprecate jaeger exporter [#​3585](https://togithub.com/open-telemetry/opentelemetry-js/pull/3585) [@​pichlermarc](https://togithub.com/pichlermarc) - fix(sdk-metrics): fix flaky LastValueAggregator test by using fake timer [#​3587](https://togithub.com/open-telemetry/opentelemetry-js/pull/3587) [@​pichlermarc](https://togithub.com/pichlermarc) - fix(test): fix failing tests by preventing source-map generation [#​3642](https://togithub.com/open-telemetry/opentelemetry-js/pull/3642) [@​pichlermarc](https://togithub.com/pichlermarc) ### [`v1.9.1`](https://togithub.com/open-telemetry/opentelemetry-js/blob/HEAD/CHANGELOG.md#191) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-js/compare/v1.9.0...v1.9.1) ##### :bug: (Bug Fix) - fix: avoid grpc types dependency [#​3551](https://togithub.com/open-telemetry/opentelemetry-js/pull/3551) [@​flarna](https://togithub.com/flarna) - fix(otlp-proto-exporter-base): Match Accept header with Content-Type in the proto exporter [#​3562](https://togithub.com/open-telemetry/opentelemetry-js/pull/3562) [@​scheler](https://togithub.com/scheler) - fix: include tracestate in export [#​3569](https://togithub.com/open-telemetry/opentelemetry-js/pull/3569) [@​flarna](https://togithub.com/flarna) ##### :house: (Internal) - chore: fix cross project links and missing implicitly exported types [#​3533](https://togithub.com/open-telemetry/opentelemetry-js/pull/3533) [@​legendecas](https://togithub.com/legendecas) - feat(sdk-metrics): add exponential histogram mapping functions [#​3504](https://togithub.com/open-telemetry/opentelemetry-js/pull/3504) [@​mwear](https://togithub.com/mwear) ### [`v1.9.0`](https://togithub.com/open-telemetry/opentelemetry-js/blob/HEAD/CHANGELOG.md#190) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-js/compare/v1.8.0...v1.9.0) ##### :rocket: (Enhancement) - feat(instrumentation-grpc): set net.peer.name and net.peer.port on client spans [#​3430](https://togithub.com/open-telemetry/opentelemetry-js/pull/3430) - feat(exporter-trace-otlp-proto): Add protobuf otlp trace exporter support for browser [#​3208](https://togithub.com/open-telemetry/opentelemetry-js/pull/3208) [@​pkanal](https://togithub.com/pkanal) ##### :bug: (Bug Fix) - fix(sdk-metrics): use default Resource to comply with semantic conventions [#​3411](https://togithub.com/open-telemetry/opentelemetry-js/pull/3411) [@​pichlermarc](https://togithub.com/pichlermarc) - Metrics exported by the SDK now contain the following resource attributes by default: - `service.name` - `telemetry.sdk.name` - `telemetry.sdk.language` - `telemetry.sdk.version` - fix(sdk-metrics): use Date.now() for instrument recording timestamps [#​3514](https://togithub.com/open-telemetry/opentelemetry-js/pull/3514) [@​MisterSquishy](https://togithub.com/MisterSquishy) - fix(sdk-trace): make spans resilient to clock drift [#​3434](https://togithub.com/open-telemetry/opentelemetry-js/pull/3434) [@​dyladan](https://togithub.com/dyladan) - fix(selenium-tests): updated webpack version for selenium test issue [#​3456](https://togithub.com/open-telemetry/opentelemetry-js/issues/3456) [@​SaumyaBhushan](https://togithub.com/SaumyaBhushan) - fix(sdk-metrics): collect metrics when periodic exporting metric reader flushes [#​3517](https://togithub.com/open-telemetry/opentelemetry-js/pull/3517) [@​legendecas](https://togithub.com/legendecas) - fix(sdk-metrics): fix duplicated registration of metrics for collectors [#​3488](https://togithub.com/open-telemetry/opentelemetry-js/pull/3488) [@​legendecas](https://togithub.com/legendecas) - fix(core): fix precision loss in numberToHrtime [#​3480](https://togithub.com/open-telemetry/opentelemetry-js/pull/3480) [@​legendecas](https://togithub.com/legendecas) ##### :house: (Internal) - chore: automatically generate tsconfigs [#​3432](https://togithub.com/open-telemetry/opentelemetry-js/pull/3432) [@​legendecas](https://togithub.com/legendecas) - chore: enforce format with prettier [#​3444](https://togithub.com/open-telemetry/opentelemetry-js/pull/3444) [@​legendecas](https://togithub.com/legendecas) ### [`v1.8.0`](https://togithub.com/open-telemetry/opentelemetry-js/blob/HEAD/CHANGELOG.md#180) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-js/compare/v1.7.0...v1.8.0) - `@opentelemetry/sdk-metrics` has been promoted to stable - `@opentelemetry/api-metrics` has been merged into `@opentelemetry/api` and deprecated ##### :boom: Breaking Change - feat(api): merge api-metrics into api [#​3374](https://togithub.com/open-telemetry/opentelemetry-js/pull/3374) [@​legendecas](https://togithub.com/legendecas) ##### :rocket: (Enhancement) - feat(sdk-trace): re-export sdk-trace-base in sdk-trace-node and web [#​3319](https://togithub.com/open-telemetry/opentelemetry-js/pull/3319) [@​legendecas](https://togithub.com/legendecas) - feat: enable tree shaking [#​3329](https://togithub.com/open-telemetry/opentelemetry-js/pull/3329) [@​pkanal](https://togithub.com/pkanal) ##### :bug: (Bug Fix) - fix(sdk-trace): enforce consistent span durations [#​3327](https://togithub.com/open-telemetry/opentelemetry-js/pull/3327) [@​dyladan](https://togithub.com/dyladan) - fix(resources): fix EnvDetector throwing errors when attribute values contain spaces [#​3295](https://togithub.com/open-telemetry/opentelemetry-js/issues/3295) - fix(trace): fix an issue which caused negative span durations in web based spans [#​3359](https://togithub.com/open-telemetry/opentelemetry-js/pull/3359) [@​dyladan](https://togithub.com/dyladan) - fix(resources): strict OTEL_RESOURCE_ATTRIBUTES baggage octet decoding [#​3341](https://togithub.com/open-telemetry/opentelemetry-js/pull/3341) [@​legendecas](https://togithub.com/legendecas) ##### :books: (Refine Doc) - doc: Added Metrics documentation [#​3360](https://togithub.com/open-telemetry/opentelemetry-js/pull/3360) [@​weyert](https://togithub.com/weyert) - docs(api): fix counter negative value wording [#​3396](https://togithub.com/open-telemetry/opentelemetry-js/pull/3396) [@​legendecas](https://togithub.com/legendecas) ##### :house: (Internal) - ci: run browser tests without circle [#​3328](https://togithub.com/open-telemetry/opentelemetry-js/pull/3328) [@​dyladan](https://togithub.com/dyladan) ### [`v1.7.0`](https://togithub.com/open-telemetry/opentelemetry-js/blob/HEAD/CHANGELOG.md#170) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-js/compare/v1.6.0...v1.7.0) ##### :bug: (Bug Fix) - fix(sdk-trace-base): make span start times resistant to hrtime clock drift [#​3129](https://togithub.com/open-telemetry/opentelemetry-js/issues/3129) - fix(sdk-trace-base): validate maxExportBatchSize in BatchSpanProcessorBase [#​3232](https://togithub.com/open-telemetry/opentelemetry-js/issues/3232) ##### :books: (Refine Doc) - docs(metrics): add missing metrics packages to SDK reference documentation [#​3239](https://togithub.com/open-telemetry/opentelemetry-js/pull/3239) [@​dyladan](https://togithub.com/dyladan) ##### :house: (Internal) - deps: update markdownlint-cli to 0.32.2 [#​3253](https://togithub.com/open-telemetry/opentelemetry-js/pull/3253) [@​pichlermarc](https://togithub.com/pichlermarc) ### [`v1.6.0`](https://togithub.com/open-telemetry/opentelemetry-js/blob/HEAD/CHANGELOG.md#160) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-js/compare/v1.5.0...v1.6.0) ##### :rocket: (Enhancement) - perf(opentelemetry-core): improve hexToBase64 performance [#​3178](https://togithub.com/open-telemetry/opentelemetry-js/pull/3178) [@​seemk](https://togithub.com/seemk) - feat(sdk-trace-base): move Sampler declaration into sdk-trace-base [#​3088](https://togithub.com/open-telemetry/opentelemetry-js/pull/3088) [@​legendecas](https://togithub.com/legendecas) - fix(grpc-instrumentation): added grpc attributes in instrumentation [#​3127](https://togithub.com/open-telemetry/opentelemetry-js/pull/3127) [@​andrewzenkov](https://togithub.com/andrewzenkov) - feat: support latest `@opentelemetry/api` [#​3177](https://togithub.com/open-telemetry/opentelemetry-js/pull/3177) [@​dyladan](https://togithub.com/dyladan) ##### :bug: (Bug Fix) - fix(context-async-hooks): Ensure listeners added using `once` can be removed using `removeListener` [#​3133](https://togithub.com/open-telemetry/opentelemetry-js/pull/3133) ##### :books: (Refine Doc) - chore: update trace-web example and rename it to opentelemetry-web [#​3145](https://togithub.com/open-telemetry/opentelemetry-js/pull/3145) [@​pichlermarc](https://togithub.com/pichlermarc) - chore: update https example [#​3152](https://togithub.com/open-telemetry/opentelemetry-js/pull/3152) [@​pichlermarc](https://togithub.com/pichlermarc) ### [`v1.5.0`](https://togithub.com/open-telemetry/opentelemetry-js/blob/HEAD/CHANGELOG.md#150) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-js/compare/v1.4.0...v1.5.0) ##### :rocket: (Enhancement) - feat(sdk-trace-base): Improve extensibility of BasicTracerProvider [#​3023](https://togithub.com/open-telemetry/opentelemetry-js/pull/3023) [@​Rauno56](https://togithub.com/Rauno56) ### [`v1.4.0`](https://togithub.com/open-telemetry/opentelemetry-js/blob/HEAD/CHANGELOG.md#140) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-js/compare/51afd54bd63e46d5d530266761144c7be2f6b3a7...v1.4.0) ##### :rocket: (Enhancement) - fix(resources): fix browser compatibility for host and os detectors [#​3004](https://togithub.com/open-telemetry/opentelemetry-js/pull/3004) [@​legendecas](https://togithub.com/legendecas) - fix(sdk-trace-base): fix crash on environments without global document [#​3000](https://togithub.com/open-telemetry/opentelemetry-js/pull/3000) [@​legendecas](https://togithub.com/legendecas) - fix(sdk-trace-base): fix spanLimits attribute length/count to consider env values [#​3068](https://togithub.com/open-telemetry/opentelemetry-js/pull/3068) [@​svetlanabrennan](https://togithub.com/svetlanabrennan) ##### :house: (Internal) - test: add node 18 and remove EoL node versions [#​3048](https://togithub.com/open-telemetry/opentelemetry-js/pull/3048) [@​dyladan](https://togithub.com/dyladan)

Configuration

📅 Schedule: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.



This PR has been generated by Mend Renovate. View repository job log here.

forking-renovate[bot] commented 11 months ago

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (~1.16.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.