fix: send all pushConfig when creating subscription

googleapis / nodejs-pubsub

Node.js client for Google Cloud Pub/Sub: Ingest event streams from anywhere, at any scale, for simple, reliable, real-time stream analytics.

https://cloud.google.com/pubsub/

Apache License 2.0

516 stars 227 forks source link

fix: send all pushConfig when creating subscription #1916

Closed useCallback closed 2 months ago

useCallback commented 2 months ago

Fixes #1915 🦕

feywind commented 2 months ago

I think as an external PR this might need a second review... can I bug you for it, @kamalaboulhosn ?

feywind commented 2 months ago

@useCallback I think you'll need to do the conflict merge, it looks like I don't have write access to the PR branch. I think the build failures aren't real (looks like someone was changing around CI stuff?), so I'll re-run once the branch is up to date.