Add shutdown options for the client classes - Githubissues

googleapis / nodejs-pubsub

Node.js client for Google Cloud Pub/Sub: Ingest event streams from anywhere, at any scale, for simple, reliable, real-time stream analytics.

https://cloud.google.com/pubsub/

Apache License 2.0

516 stars 227 forks source link

Add shutdown options for the client classes #1917

Open feywind opened 2 months ago

feywind commented 2 months ago

We are planning to add updates to the close() methods to allow for a more deterministic shutdown process. This will take care of issues like these:

https://github.com/googleapis/nodejs-pubsub/issues/1860 https://github.com/googleapis/nodejs-pubsub/issues/1856 https://github.com/googleapis/nodejs-pubsub/issues/1665 https://github.com/googleapis/nodejs-pubsub/issues/1648

The three options boil down to this:

Wait for everything to finish dequeuing
Bail immediately (and maybe return IDs of things that were pending)
Nack everything in the queue and wait for those to send