fix(docs samples): update missing argv in sample metadata of push subscription

googleapis / nodejs-pubsub

Node.js client for Google Cloud Pub/Sub: Ingest event streams from anywhere, at any scale, for simple, reliable, real-time stream analytics.

https://cloud.google.com/pubsub/

Apache License 2.0

516 stars 227 forks source link

fix(docs samples): update missing argv in sample metadata of push subscription #1946

Closed telosma closed 1 week ago

telosma commented 2 weeks ago

What

Sample metadata usage for creating a push subscription is missing the push endpoint

google-cla[bot] commented 2 weeks ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

generated-files-bot[bot] commented 2 weeks ago

Warning: This pull request is touching the following templated files:

samples/README.md - samples/README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml

feywind commented 2 weeks ago

Those linter issues aren't a problem with this PR.

feywind commented 1 week ago

Sorry for the delay, we had some CI hiccups.