search

googleapis / nodejs-spanner

Node.js client for Google Cloud Spanner: the world’s first fully managed relational database service to offer both strong consistency and horizontal scalability.
https://cloud.google.com/spanner/
Apache License 2.0
135 stars 100 forks source link

chore: Skip archived test #2018

Closed surbhigarg92 closed 6 months ago

generated-files-bot[bot] commented 6 months ago

Warning: This pull request is touching the following templated files:

surbhigarg92 commented 6 months ago

LGTM, but can we make sure we have a plan to run these archived samples in some way? We could otherwise not detect issues with those samples. Few thoughts on doing this,

  1. Run the archived samples in continuous and nightly builds thus leaving out presubmits.
  2. Run active and archived samples in presubmit only when there are changes in samples directory.

There could be some other better strategy but having this would help us find any regressions in archived samples.

Added the change to make sure we are running archived tests in continuous and nightly builds