search

googleapis / nodejs-spanner

Node.js client for Google Cloud Spanner: the world’s first fully managed relational database service to offer both strong consistency and horizontal scalability.
https://cloud.google.com/spanner/
Apache License 2.0
135 stars 98 forks source link

Database.getDatabaseDialect's "cb" argument is never used #2075

Closed odeke-em closed 1 month ago

odeke-em commented 1 month ago

If we examine the method "getDatabaseDialect" https://github.com/googleapis/nodejs-spanner/blob/30151cad2723d6a9f2c70342c81f1a578ee02f6a/src/database.ts#L1530-L1553 we can see that the callback passed in is never used. I found this while working on trace instrumentation for these libraries.

alkatrivedi commented 1 month ago

Hi @odeke-em, thanks for pointing it out. I have raised a PR to fix this issue