search

googleapis / nodejs-spanner

Node.js client for Google Cloud Spanner: the world’s first fully managed relational database service to offer both strong consistency and horizontal scalability.
https://cloud.google.com/spanner/
Apache License 2.0
135 stars 99 forks source link

chore: callback method in getDatabaseDialect #2078

Closed alkatrivedi closed 1 month ago

alkatrivedi commented 2 months ago

fixes: #2075

alkatrivedi commented 2 months ago

Thanks for approving the PR @odeke-em

surbhigarg92 commented 1 month ago

@alkatrivedi Please add a unit test case .

alkatrivedi commented 1 month ago

@alkatrivedi Please add a unit test case .

A unit test already exists for this