feat: (observability) add spans for BatchTransaction and Table

googleapis / nodejs-spanner

Node.js client for Google Cloud Spanner: the world’s first fully managed relational database service to offer both strong consistency and horizontal scalability.

https://cloud.google.com/spanner/

Apache License 2.0

136 stars 101 forks source link

feat: (observability) add spans for BatchTransaction and Table #2115

Closed odeke-em closed 1 month ago

odeke-em commented 1 month ago

This change is part of a series of changes to add OpenTelemetry traces, focused on BatchTransaction and Table.

While here, made the tests for sessionPool spans much more precise to avoid flakes.

Updates #2079 Built from PR #2087 Updates #2114

surbhigarg92 commented 1 month ago

@odeke-em I don't see any tests for these spans.

odeke-em commented 1 month ago

Hey @surbhigarg92 I hadn't uploaded some of them as I created this PR early morning at around 3AM before bed and in interludes. I've added comprehensive tests, please take a look.