search

googleapis / nodejs-spanner

Node.js client for Google Cloud Spanner: the world’s first fully managed relational database service to offer both strong consistency and horizontal scalability.
https://cloud.google.com/spanner/
Apache License 2.0
136 stars 102 forks source link

Doc links no longer work without the .html extension #662

Closed hegemonic closed 5 years ago

hegemonic commented 5 years ago

As recently as one or two days ago, you could link to the Node.js API docs without including the .html file extension. For example, this link worked: https://googleapis.dev/nodejs/spanner/latest/Table

Today, opening that link results in a 404, and you have to include the .html extension: https://googleapis.dev/nodejs/spanner/latest/Table.html

This change breaks a number of links to the API docs from cloud.google.com.

@bcoe FYI

bcoe commented 5 years ago

@hegemonic we have never supported dropping the .html extension on googleapis.dev (this rewrite rule is something applied by the CMS serving cloud.google.com).

However, a regex is used to append a .html onto any historical links on cloud.google.com, see:

https://cloud.google.com/nodejs/docs/reference/spanner/latest/Table

My guess is that there was a link added to cloud.google.com that's simply missing the .html; the googleapis.dev service currently runs no intermediate proxy, serving directly out of a storage bucket, tldr; it doesn't currently support any URL rewriting.

hegemonic commented 5 years ago

To clarify: Links to googleapis.dev were definitely working without the .html extension at the beginning of this week, however unlikely that might sound. I tested those links a week or two ago, when I updated the Cloud Spanner docs to point to googleapis.dev instead of cloud.google.com, and the cloud.google.com link checker didn't start complaining about those links until shortly before I filed this bug.

But it sounds like that was just a happy accident, or it was caused by cosmic rays, or who knows what, not the intended behavior. I've updated the links on cloud.google.com already, so I'll close this bug.