search

googleapis / nodejs-storage

Node.js client for Google Cloud Storage: unified object storage for developers and enterprises, from live data serving to data analytics/ML to data archiving.
https://cloud.google.com/storage/
Apache License 2.0
897 stars 369 forks source link

cleanup(deps): Consideration of removing an unnecessary dependency (abort-controller) #2211

Open SandZn opened 1 year ago

SandZn commented 1 year ago

Hi,

I'm doing research on detecting unnecessary dependencies in NodeJs packages. I found that one dependency (abort-controller) is not necessary for your package.

I modified the package.json file to remove the abort-controller dependency, and I ran your tests. The testing result showed that all tests passed, and the test coverage did not change before and after I removed this dependency.

Would you consider removing this dependency to enhance security and reduce maintenance costs?

ddelgrosso1 commented 1 year ago

Hi @SandZn unfortunately I do not think this is possible at this time. This library currently supports Node >= 12. AbortController did not become stable in Node until v15.4.0 . I am assuming you tested with a version >= 15.4.0 is that correct?

SandZn commented 1 year ago

Correct. My node version is v16.17.0. Thank you for your response.

ddelgrosso1 commented 1 year ago

@SandZn I'm going to keep this issue open and just update the title a bit to reflect the desire. When we move minimum node versions we would certainly be happy to remove abort-controller.