googleapis / nodejs-storage

Node.js client for Google Cloud Storage: unified object storage for developers and enterprises, from live data serving to data analytics/ML to data archiving.
https://cloud.google.com/storage/
Apache License 2.0
897 stars 369 forks source link

build: type the return of xml.parse to fix compilation problem with 4.3.0 #2307

Closed ddelgrosso1 closed 11 months ago

ddelgrosso1 commented 11 months ago

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes # 🦕

ddelgrosso1 commented 11 months ago

fast-xml-parser v4.3.0 was released yesterday. Looks like stronger typing requirements were added to .parse which is breaking the build. See: https://github.com/NaturalIntelligence/fast-xml-parser/pull/594