fix: simplify the code for downloadInChunks

googleapis / nodejs-storage

Node.js client for Google Cloud Storage: unified object storage for developers and enterprises, from live data serving to data analytics/ML to data archiving.

https://cloud.google.com/storage/

Apache License 2.0

897 stars 369 forks source link

fix: simplify the code for downloadInChunks #2323

Closed ddelgrosso1 closed 11 months ago

ddelgrosso1 commented 11 months ago

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes # 🦕

ddelgrosso1 commented 11 months ago

Realized this could be a bit cleaner by using await / try / finally instead of returning a new promise.

ddelgrosso1 commented 11 months ago

@danielduhh just cleanup / simplification.